chore: factor out check_columns_exist #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narwhals/utils.py
Outdated
| @@ -1059,3 +1059,9 @@ def generate_repr(header: str, native_repr: str) -> str: | |||
| "| Use `.to_native` to see native output |\n└" | |||
| f"{'─' * 39}┘" | |||
| ) | |||
|
|
|||
|
|
|||
| def check_column_exists(columns: list[str], subset: str | list[str] | None) -> None: | |||
There was a problem hiding this comment.
doesn't subset need to be a list here?
Suggested change
| def check_column_exists(columns: list[str], subset: str | list[str] | None) -> None: | |
| def check_column_exists(columns: list[str], subset: list[str] | None) -> None: |
There was a problem hiding this comment.
looks like this is wrong in _spark_like actually - could you correct that one from
subset: str | list[str] | None = None,
to
subset: list[str] | None = None,
please?
|
as another follow-up, we could show which columns are missing? like ? |
|
Yeah, sure @MarcoGorelli. Did I close this too soon? 😱 |
|
😄 no i meant in another pr, if you fancy it |
|
Sure, sure! 🙂 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
check_columns_exist#1736Checklist
If you have comments or can explain your changes, please do so below