Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always pass Column to pandas.spark.functions #1712

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

EdAbati
Copy link
Collaborator

@EdAbati EdAbati commented Jan 3, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

I guess it was not picked up in the CI because numpy version is > 2.0.
Should we have an extra test session with numpy<2.0 and pyspark?

@EdAbati EdAbati marked this pull request as ready for review January 3, 2025 11:50
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted and fixed! Thanks @EdAbati πŸš€

Should we have an extra test session with numpy<2.0 and pyspark?

I am ok to add it to our CI

NarwhalChubbiwhalGIF

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks both!

@MarcoGorelli MarcoGorelli merged commit 6b823f3 into narwhals-dev:main Jan 3, 2025
24 checks passed
@EdAbati EdAbati deleted the fix-std-var-tests branch January 3, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants