Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove unnecessary pytest filterwarnings #1691

Merged
merged 15 commits into from
Jan 5, 2025

Conversation

DeaMariaLeon
Copy link
Member

@DeaMariaLeon DeaMariaLeon commented Dec 31, 2024

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Tests pass locally. Am I missing something?

Edit: warnings appear with older versions then (I only tested one old version locally)

@MarcoGorelli
Copy link
Member

thanks! looks like we may need to catch and filter out some of these during _pyspark_constructor_with_session, but the rest are probably good to go

@MarcoGorelli MarcoGorelli changed the title tests: removing filters tests: remove unnecessary pytest filterwarnings Jan 5, 2025
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @DeaMariaLeon , this kind of thing can be frustrating but makes a difference in the long run, much appreciated!

@MarcoGorelli MarcoGorelli merged commit 9f4b419 into narwhals-dev:main Jan 5, 2025
24 checks passed
@DeaMariaLeon DeaMariaLeon deleted the errors branch January 5, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants