Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raise informative error message when grouping by expressions #1677

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

MarcoGorelli
Copy link
Member

This has come up a couple of times on discord

it may be possible to support this, but i don't have time right now, so i'd say that for now let's raise a proper error message and we can revisit later if necessary

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Dec 29, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 29, 2024 19:57
@MarcoGorelli MarcoGorelli merged commit f656fb3 into narwhals-dev:main Dec 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant