ci: improve publish ci to use env vars #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks - think there's on emore change that needs doing from the linked pr? |
|
@MarcoGorelli I guess not! Do you have any suggestions? |
|
I think there's the other change that still needs doing? |
…into enh/use_env_in_publish_ci
|
Hey @MarcoGorelli, I updated the PR. Just let me know if this what you meant. I might be missing some context😅 |
MarcoGorelli
approved these changes
Dec 27, 2024
MarcoGorelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
publish_to_pypi.yml#1647publish_to_pypi.yml#1647Checklist
If you have comments or can explain your changes, please do so below
This PR just improves the publish_to_pypi.yml to use the environment variables.