Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Relax cuDF minimum version to 24.10.0 #1649

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

MarcoGorelli
Copy link
Member

This recent cudf change would actually break "cudf in Plotly", so I don't think we can bump up the cuDF version so much

It's not that much complexity to allow for the previous behaviour here too

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 27, 2024 10:59
@MarcoGorelli MarcoGorelli merged commit a4fbcb4 into narwhals-dev:main Dec 27, 2024
24 checks passed
@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant