Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: returns and arguments documentation for lazyframe class #1630

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

marenwestermann
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @marenwestermann , feel free to ship when ready!

@marenwestermann
Copy link
Contributor Author

Thanks for the super fast review! πŸ˜€ Now the CI is green!

Alt Text

@marenwestermann marenwestermann merged commit 35b1849 into narwhals-dev:main Dec 20, 2024
24 checks passed
@marenwestermann marenwestermann deleted the lazyframe-docs branch December 20, 2024 15:44
@MarcoGorelli MarcoGorelli added the documentation Improvements or additions to documentation label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants