Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minimum versions #1617

Merged
merged 3 commits into from
Dec 19, 2024
Merged

test: minimum versions #1617

merged 3 commits into from
Dec 19, 2024

Conversation

DeaMariaLeon
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@DeaMariaLeon
Copy link
Member Author

DeaMariaLeon commented Dec 19, 2024

So, it's installing pyarrow==17.0.0 but I'm checking for pyarrow==11.0.0
This problem was also commented on this other PR

Is the purpose of the original issue just show what was installed or actually fix this problem?

@FBruzzesi
Copy link
Member

FBruzzesi commented Dec 19, 2024

Hey Dea, thanks for addressing this!

Is the purpose of the original issue just show what was installed or actually fix this problem?

I would say that achieving both would be ideal to unblock any other contribution:

@MarcoGorelli
Copy link
Member

thanks! once #1613 is in we can merge this one

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks both! good to go on green πŸ₯¦

@MarcoGorelli MarcoGorelli merged commit 4cbf646 into narwhals-dev:main Dec 19, 2024
24 checks passed
@DeaMariaLeon DeaMariaLeon deleted the show branch December 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants