Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make docstring examples function names more descriptive in functions.py #1602

Conversation

Machele-codez
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli
Copy link
Member

thanks, could you make sure pytest narwhals --doctest-modules passes please?

@Machele-codez
Copy link
Contributor Author

thanks, could you make sure pytest narwhals --doctest-modules passes please?

Working on it πŸ‘

@Machele-codez
Copy link
Contributor Author

@MarcoGorelli done now πŸ‘

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit 4c203f6 into narwhals-dev:main Dec 16, 2024
23 checks passed
@MarcoGorelli MarcoGorelli added the documentation Improvements or additions to documentation label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants