Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use set_axis in maybe_set_index #1598

Merged
merged 1 commit into from
Dec 15, 2024
Merged

chore: use set_axis in maybe_set_index #1598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions narwhals/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,18 +548,18 @@ def maybe_set_index(
df_any._compliant_frame._from_native_frame(native_obj.set_index(keys))
)
elif is_pandas_like_series(native_obj):
from narwhals._pandas_like.utils import set_axis

if column_names:
msg = "Cannot set index using column names on a Series"
raise ValueError(msg)

if (
df_any._compliant_series._implementation is Implementation.PANDAS
and df_any._compliant_series._backend_version < (1,)
): # pragma: no cover
native_obj = native_obj.set_axis(keys, inplace=False)
else:
native_obj = native_obj.set_axis(keys)

native_obj = set_axis(
native_obj,
keys,
implementation=obj._compliant_series._implementation, # type: ignore[union-attr]
backend_version=obj._compliant_series._backend_version, # type: ignore[union-attr]
)
return df_any._from_compliant_series( # type: ignore[no-any-return]
df_any._compliant_series._from_native_series(native_obj)
)
Expand Down
Loading