feat: add **kwargs to read_csv and scan_csv
#1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
thanks @raisadz !
just one minor comment
also, if we could include a teeny tiny little test which uses nw.read_csv('file.csv', native_namespace=pd, engine='pyarrow') that'd be grand
| elif implementation is Implementation.PYARROW: | ||
| from pyarrow import csv # ignore-banned-import | ||
|
|
||
| native_frame = csv.read_csv(source) | ||
| native_frame = csv.read_csv(source, **kwargs) |
There was a problem hiding this comment.
i think we need to pass them in line 1020 too?
| elif implementation is Implementation.DASK: | ||
| native_frame = native_namespace.read_csv(source) | ||
| native_frame = native_namespace.read_csv(source, **kwargs) |
tests/read_csv_test.py
Outdated
| @@ -40,3 +41,13 @@ def test_read_csv_v1( | |||
| result = nw_v1.read_csv(filepath, native_namespace=native_namespace) | |||
| assert_equal_data(result, data) | |||
| assert isinstance(result, nw_v1.DataFrame) | |||
|
|
|||
|
|
|||
| def test_read_csv_kwargs( | |||
There was a problem hiding this comment.
this is failing on the minimum versions
can we use skipif with the pandas version < (1,5)? there's some other tests that do something like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below