Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix nox dependencies #1497

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented Dec 4, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

If the dependencies are not in a list[str], the following fails locally:

Screenshot 2024-12-04 at 09 12 53

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @EdAbati !

@MarcoGorelli MarcoGorelli merged commit eebc89a into narwhals-dev:main Dec 4, 2024
24 checks passed
@EdAbati EdAbati deleted the nox-fix branch December 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants