feat: consistently return Python scalars from Series reductions for PyArrow #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
reviewed
Nov 30, 2024
narwhals/_arrow/series.py
Outdated
Comment on lines
35
to
38
| def maybe_extract_py_scalar(value: Any, return_py_scalar: bool) -> Any: # noqa: FBT001 | ||
| if return_py_scalar: | ||
| return to_py_scalar(value) | ||
| return value |
There was a problem hiding this comment.
Should we target this to arrow specifically instead of using the more generic to_py_scalar?
Comment on lines
+229
to
+233
| extra_kwargs = ( | ||
| {"_return_py_scalar": False} | ||
| if returns_scalar and expr._implementation is Implementation.PYARROW | ||
| else {} | ||
| ) |
Co-authored-by: Francesco Bruzzesi <[email protected]>
|
thanks @FBruzzesi ! any other comments? |
I am from mobile but it seems good! Thanks for addressing both points :) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below