feat: create dataframe from 2D numpy array and column names #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
reviewed
Nov 29, 2024
narwhals/functions.py
Outdated
Comment on lines
450
to
451
| native_namespace: The native library to use for DataFrame creation. Only | ||
| necessary if inputs are not Narwhals Series. |
There was a problem hiding this comment.
Suggested change
| native_namespace: The native library to use for DataFrame creation. Only | |
| necessary if inputs are not Narwhals Series. | |
| native_namespace: The native library to use for DataFrame creation. |
narwhals/functions.py
Outdated
| @@ -430,6 +432,163 @@ def _from_dict_impl( | |||
| return from_native(native_frame, eager_only=True) | |||
|
|
|||
|
|
|||
| def from_numpy( | |||
| data: np.ndarray, | |||
| schema: dict[str, DType] | Schema | None = None, | |||
There was a problem hiding this comment.
I think it would be nice to support list[str] as column names. In my opinion is way more common to specify the names of the columns without their dtypes when creating a dataframe
There was a problem hiding this comment.
Agreed, I added this as an option for schema
narwhals/functions.py
Outdated
| } | ||
| native_frame = native_namespace.from_numpy(data, schema=schema_pl) | ||
| else: | ||
| native_frame = native_namespace.from_numpy(data, orient="col") |
There was a problem hiding this comment.
Why are we defaulting to orient="col"? To me this seems the opposite of what polars does if nothing else is provided:
import numpy as np
import polars as pl
data = np.array([[5, 2, 1], [1, 4, 3]])
data
array([[5, 2, 1],
[1, 4, 3]])
pl.from_numpy(data)
shape: (2, 3)
┌──────────┬──────────┬──────────┐
│ column_0 ┆ column_1 ┆ column_2 │
│ --- ┆ --- ┆ --- │
│ i64 ┆ i64 ┆ i64 │
╞══════════╪══════════╪══════════╡
│ 5 ┆ 2 ┆ 1 │
│ 1 ┆ 4 ┆ 3 │
└──────────┴──────────┴──────────┘while:
pl.from_numpy(data, orient="col")
shape: (3, 2)
┌──────────┬──────────┐
│ column_0 ┆ column_1 │
│ --- ┆ --- │
│ i64 ┆ i64 │
╞══════════╪══════════╡
│ 5 ┆ 1 │
│ 2 ┆ 4 │
│ 1 ┆ 3 │
└──────────┴──────────┘This translates to the array transpose in pandas
There was a problem hiding this comment.
Hey @FBruzzesi, thanks for your review! I fixed the orientation from columns to rows
raisadz
force-pushed
the
from-numpy
branch
5 times, most recently
from
b8feada
to
c93a78f
Compare
MarcoGorelli
force-pushed
the
from-numpy
branch
from
c93a78f
to
ff9cc83
Compare
|
and thanks @FBruzzesi for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below