feat: diagonal concat #1455
Merged
feat: diagonal concat #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Nov 28, 2024
| if implementation is Implementation.PANDAS and backend_version < (3,) | ||
| else {} | ||
| ) | ||
| return implementation.to_native_namespace().concat(dfs, axis=0, **extra_kwargs) |
There was a problem hiding this comment.
this is the unfiltered/unchecked default pandas behavior for vertical concat
MarcoGorelli
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
thanks @FBruzzesi ! tried this out in Prophet and it worked exactly as intended!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
how='diagonal'inconcat#1436Checklist