enh: Add .rows(named=False) support for pyarrow
#1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slow support is better than no support
schloerke
commented
Oct 8, 2024
schloerke
commented
Oct 8, 2024
FBruzzesi
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Hey @schloerke , thanks for the PR! I tend to agree with the statement:
I'm in the camp of slow support is better than no support.
Not sure about Marco's opinion though.
Regarding the failing CI, you should remove the part of the tests that explicitly fails/raises for pyarrow case
|
@FBruzzesi Fixed 😄 Narwhal's testing, pre-commit, and |
|
thanks both! i'm just at a company retreat but i'll try to merge / release tomorrow |
MarcoGorelli
approved these changes
Oct 11, 2024
akmalsoliev
pushed a commit
to akmalsoliev/narwhals
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the camp of slow support is better than no support.
If there ever comes a time that pyarrow supports retrieving row values more natively, then this code can be updated.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
posit-dev/py-shiny uses
.rows(named=False)to retrieve the values