Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: xfail tz_aware test for cuDF #1118

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

LiamConnors
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@LiamConnors LiamConnors marked this pull request as ready for review October 3, 2024 00:36
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LiamConnors , appreciate the comments!

@MarcoGorelli MarcoGorelli merged commit 1a9af18 into narwhals-dev:main Oct 3, 2024
22 checks passed
akmalsoliev pushed a commit to akmalsoliev/narwhals that referenced this pull request Oct 15, 2024
* xfail tz_aware for cuDF

* add GitHub issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants