feat: add Series.dtype return annotation
#1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
changed the title
Series.dtype return annotation
schloerke
reviewed
Sep 23, 2024
| @@ -302,7 +303,7 @@ def len(self) -> int: | |||
| return len(self._compliant_series) | |||
|
|
|||
| @property | |||
| def dtype(self) -> Any: | |||
| def dtype(self: Self) -> DType: | |||
schloerke
reviewed
Sep 23, 2024
| @@ -359,7 +359,7 @@ def alias(self, name: str) -> Self: | |||
| ) | |||
|
|
|||
| @property | |||
| def dtype(self) -> DType: | |||
| def dtype(self: Self) -> DType: | |||
There was a problem hiding this comment.
I don't believe it's needed
Suggested change
| def dtype(self: Self) -> DType: | |
| def dtype(self) -> DType: |
But if it is... Can you please teach me why? Thank you
There was a problem hiding this comment.
I took this as opportunity to go a bit banana into hints for the rest of the codebase (uncommitted here). When we know that self: Self, then self._native_series is known to be a pa.ChunkedArray, which has a type property.
Probably some editors do not need it anyway 😇
There was a problem hiding this comment.
sounds like something which editors should fix 😄 but in the meantime, if this helps the development workflow, then it seems like a good idea to add it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
nw.DTypefromSeries's.dtypeproperty #1047Checklist
If you have comments or can explain your changes, please do so below.