Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add str.len_chars #1036

Merged
merged 5 commits into from
Sep 21, 2024
Merged

Conversation

lucianosrp
Copy link
Member

@lucianosrp lucianosrp commented Sep 21, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

It has been a while... 🫣

@github-actions github-actions bot added the enhancement New feature or request label Sep 21, 2024
@lucianosrp lucianosrp marked this pull request as ready for review September 21, 2024 14:05
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is amazing, thanks @lucianosrp !

@MarcoGorelli MarcoGorelli merged commit 827d8de into narwhals-dev:main Sep 21, 2024
22 checks passed
@lucianosrp lucianosrp deleted the feat/str-len-chars branch September 21, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants