-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tuple supported for getitem for Pandas dataframes #1026
fix: tuple supported for getitem for Pandas dataframes #1026
Conversation
β¦e-supported-for-getitem/dev
β¦v' into fix/tuple-supported-for-getitem/dev
This PR is ready for review. |
.gitignore
Outdated
@@ -34,6 +34,3 @@ tpch/data/* | |||
|
|||
# MacOS | |||
.DS_Store | |||
|
|||
# IntelliJ IDEA | |||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Riik why was this removed? I would consider this the same as .vscode
but then for IntelliJ and Pycharm. It should not be pushed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be easier to have .idea in gitginore as well, but figured it was easier to keep that separate from this PR since it was just about the bug ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the README clean up then too :)
@MarcoGorelli @Riik @windiana42 PS: Here is the video that showed me that |
for more information, see https://pre-commit.ci
β¦-for-getitem/dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Riik @windiana42 @mikeweltevrede !
What type of PR is this? (check all applicable)
Related issues
tuple()
Β #990Checklist
If you have comments or can explain your changes, please do so below.
To close #990 we now make sure that Pandas-like Dataframes can be indexed with tuples to support Polars-like behaviour.