Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Skeleton Generator Type #29 #34

Merged
merged 10 commits into from
Aug 9, 2018
Merged

Skeleton Generator Type #29 #34

merged 10 commits into from
Aug 9, 2018

Conversation

prisis
Copy link
Member

@prisis prisis commented Aug 4, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29
License MIT
Doc PR -

@prisis prisis changed the title first work on #29 Skeleton Generator Type #29 Aug 4, 2018
@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #34 into master will decrease coverage by 7.42%.
The diff coverage is 62.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
- Coverage     55.46%   48.04%   -7.43%     
- Complexity      482      517      +35     
============================================
  Files            29       35       +6     
  Lines          1244     1430     +186     
============================================
- Hits            690      687       -3     
- Misses          554      743     +189
Impacted Files Coverage Δ Complexity Δ
src/Automatic/Prefetcher/ComposerRepository.php 0% <0%> (ø) 6 <0> (ø) ⬇️
...c/Common/Installer/AbstractInstallationManager.php 0% <0%> (-98.49%) 22 <18> (+3)
src/Automatic/Prefetcher/Prefetcher.php 0% <0%> (-19.77%) 38 <0> (ø)
src/Automatic/Installer/InstallationManager.php 0% <0%> (ø) 19 <19> (?)
src/Common/Installer/Installer.php 100% <100%> (ø) 8 <0> (+1) ⬆️
src/Automatic/Configurator.php 100% <100%> (ø) 3 <3> (-10) ⬇️
src/Common/Generator/AbstractGenerator.php 100% <100%> (ø) 4 <4> (?)
src/Automatic/PackageConfigurator.php 100% <100%> (ø) 1 <1> (-10) ⬇️
src/Automatic/Installer/SkeletonInstaller.php 100% <100%> (ø) 1 <1> (?)
src/Automatic/SkeletonGenerator.php 100% <100%> (ø) 14 <14> (?)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67331b2...3d002dc. Read the comment docs.

prisis and others added 8 commits August 6, 2018 01:11
added a installation manger
added tests for the new classes
added a classmap
added toJson to package
added some test
@todo fix all tests
refactored some classes and added const
added tests and fixed some
cs fixes and phpstan fixes
@prisis prisis merged commit 94da73f into master Aug 9, 2018
@prisis prisis deleted the issue-29 branch August 9, 2018 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant