Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending emails in a loop causing _formData to persist #39

Open
ajibarra opened this issue Dec 2, 2022 · 0 comments
Open

Sending emails in a loop causing _formData to persist #39

ajibarra opened this issue Dec 2, 2022 · 0 comments

Comments

@ajibarra
Copy link

ajibarra commented Dec 2, 2022

In Cake4, Mailer class clone transport before executing deliver method, then it restores the transport instance. When MailgunTransport is clone, the FormData instance in _formData property is shared between the two instances (original and clone) so even when _reset is called after sending email, the cloned instance keeps the previous _formData generating emails with multiple to, subject and from headers.

Calling _reset in new instance fixes the issue

ajibarra added a commit to CakeDC/cakephp-mailgun that referenced this issue Dec 2, 2022
ajibarra added a commit to CakeDC/cakephp-mailgun that referenced this issue Dec 2, 2022
ajibarra added a commit to CakeDC/cakephp-mailgun that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant