Dark theme logo in README #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The REAME logo looks the same for me in your repo, despite using the dark theme. Does it look different for you? |
|
Yes for me the logo switches correctly, tested on mobile and desktop on Chrome, Edge and Firefox. Dark theme: Light theme: |
|
Thanks for confirming. I think I don't see this change because my dark theme is set in the GitHub settings rather than the browser settings. Regardless, merging in as this should improve the appearance for some number of users. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a white background on the original logo image doesn't look the best on dark theme.
Added a white lined logo with a transparent background.
Kept the original HTML
<img>in the readme but addedprefers-color-scheme: darksource element.