Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode support #22

Open
neuromusic opened this issue Oct 14, 2021 · 5 comments
Open

dark mode support #22

neuromusic opened this issue Oct 14, 2021 · 5 comments
Labels
enhancement New feature or request needs design

Comments

@neuromusic
Copy link
Collaborator

from October 2021 pre-launch bug bash

Created by: Justin

Description

theme (along with hub) should support "dark mode" when user's browser is in dark mode

Info

Bug source: unknown

Browser: unknown

PR: none

Attachments

@neuromusic
Copy link
Collaborator Author

as noted in napari/napari.github.io#146, part of this work will need to account for images under light/dark mode

note, GitHub now supports this in markdown files: https://twitter.com/github/status/1463556704436637707

@neuromusic
Copy link
Collaborator Author

is there a way to determine how many visitors to napari.org have their system/browser set for dark mode? can we pull this into plausible?

@neuromusic neuromusic transferred this issue from napari/napari.github.io Jan 28, 2022
@jni jni mentioned this issue Mar 22, 2022
@codemonkey800 codemonkey800 added enhancement New feature or request P3 labels Mar 30, 2022
@psobolewskiPhD
Copy link
Member

I'm very for a light and native dark theme, because I autoswitch on my Macs.
With the new theme #134 we should have a ccess to dark mode natively.
It would need to be enabled in napari/docs if I am understanding correctly.
CC: @melissawm Shall we move this issue?

@melissawm
Copy link
Member

I actually think this could be kept here, because as much as we need to turn it on and off in napari/docs, the actual styling will go here. I am unsure even how to treat this as I don't really know how a dark theme would look good here. We might need someone with design chops for this.

@psobolewskiPhD
Copy link
Member

Sounds good.
I'm honestly shocked the site isn't dark by default given the dark theme of napari being the default!
I'll take a look at what my darkening extension does with the new site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs design
Projects
Development

No branches or pull requests

4 participants