Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either provide a Dark theme or don't have advertise a dark theme #124

Closed
psobolewskiPhD opened this issue Oct 27, 2022 · 5 comments · Fixed by napari/docs#423
Closed

Either provide a Dark theme or don't have advertise a dark theme #124

psobolewskiPhD opened this issue Oct 27, 2022 · 5 comments · Fixed by napari/docs#423
Assignees

Comments

@psobolewskiPhD
Copy link
Member

Related to #22
I use an extension (Noir in Safari) that darkens websites that don't have a dark mode to match my system settings: light during the day, dark at night.
napari.org isn't darkened by this extention, because according to the extension it provides a dark mode. But t o my eyes, it's just the light mode. So I have to either manually override each time in the evening/night or have napari.org permanently-dark which I don't want either.

@jni
Copy link
Member

jni commented Nov 20, 2022

Also related to #113 😞

@melissawm
Copy link
Member

We can track this on #22 now that we don't advertise a dark mode anymore (I believe!)

@psobolewskiPhD
Copy link
Member Author

My darkening extension is still detecting a Dark theme:
image
so it's not darkening the page. So somewhere, something is triggering. I will look into this some more later.

@psobolewskiPhD psobolewskiPhD reopened this Feb 6, 2024
@psobolewskiPhD psobolewskiPhD self-assigned this Feb 6, 2024
@psobolewskiPhD
Copy link
Member Author

psobolewskiPhD commented Feb 6, 2024

I see this in my Safari dev console:
[Log] [PST]: Changed to auto mode using the light theme. (pydata-sphinx-theme.js, line 1)
When I load with Light system theme. With Dark system theme it's ... dark theme
So it looks like even though we don't offer a dark theme and the controls are disabled we are in auto mode.

Looking at docs:
https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html#light-and-dark-themes
Maybe we just need to add:

html_context = {
   # ...
   "default_mode": "light"
}

@melissawm
Copy link
Member

Argh. Thanks for checking!

@psobolewskiPhD psobolewskiPhD linked a pull request May 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants