Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar details view improvement suggestions #138

Closed
3 tasks done
jni opened this issue Jan 18, 2024 · 5 comments · Fixed by napari/docs#337
Closed
3 tasks done

Calendar details view improvement suggestions #138

jni opened this issue Jan 18, 2024 · 5 comments · Fixed by napari/docs#337

Comments

@jni
Copy link
Member

jni commented Jan 18, 2024

  • Ideally, it should be dismissable by clicking anywhere outside of the details box
  • It should also be dismissable with Esc
  • It should be centered on the page or near the click, so that one can quickly look at many events in sequence.

CC @melissawm @psobolewskiPhD

Just implementing the easiest one of the above would be enough for a first pass. Right now, there's a lot of mousing back and forth between the calendar and the X to close the event!

@psobolewskiPhD
Copy link
Member

The first 2 are priorities, IMO.
For me the 3rd is take it or leave it. I actually rather like the current less in the way implementation on a larger monitor--I can see the calendar and the event. On a small screen it's basically centered anyways.

Super minor thing:
the dates (e.g. 17) and days of the week "light up" on hover, like they should do something when you click, but they don't.

BTW: for me it shows all times America New York is that for everyone? I think if it could be aware of time zones it would be amazing.

@melissawm
Copy link
Member

melissawm commented Jan 18, 2024

It is - that should be your time zone. Is it not? Maybe that's a browser thing again?

Screenshot_2024-01-18-17-45-00-594_org.mozilla.firefox-edit.jpg

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Jan 18, 2024

Nono, sorry I wasn't clear -- it was showing me my timezone! I wasn't sure if it wasn't if it was showing the same times for everyone (with the message re: timezone) or actually adapting. Looks like it adapts, which is killer!
❤️

@melissawm
Copy link
Member

The event popover looks awful on mobile because I hardcoded it to be 20% of the screen - needs to be made responsive 😅

Screenshot_2024-01-18-19-15-28-263_org.mozilla.firefox.jpg

Czaki added a commit to napari/docs that referenced this issue Jan 31, 2024
# References and relevant issues
Closes napari/napari-sphinx-theme#138, together with
napari/napari-sphinx-theme#147

# Description
Clicking outside of the calendar event modal or pressing the ESC key
closes the modal.

---------

Co-authored-by: Grzegorz Bokota <[email protected]>
@jni
Copy link
Member Author

jni commented Jan 31, 2024

Amazing work as always @melissawm! 😍 Man I am so pumped to see this live on the stable site!

Czaki added a commit to napari/napari that referenced this issue Jan 31, 2024
# References and relevant issues
Closes napari/napari-sphinx-theme#138, together with
napari/napari-sphinx-theme#147

# Description
Clicking outside of the calendar event modal or pressing the ESC key
closes the modal.

---------

Co-authored-by: Grzegorz Bokota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants