Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NAP-6 to remove mention of context menu #525

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

jni
Copy link
Member

@jni jni commented Nov 19, 2024

References and relevant issues

haesleinhuepf/napari-segment-blobs-and-things-with-membranes#45 (comment)

While working on a PR with a plugin developer to update their plugin to use
NAP-6, it became clear that starting with the non-contributable layer context
menu at the very top of the NAP is very user-unfriendly. 😅

Description

In this PR, I remove mentions of the layer context menu and instead replace the
first example in the NAP with one that works.

@jni
Copy link
Member Author

jni commented Nov 19, 2024

CC @DragaDoncila

@jni jni requested a review from DragaDoncila November 19, 2024 03:48
@jni
Copy link
Member Author

jni commented Nov 19, 2024

Sorry, I've been away for a bit — can someone explain what happened to our labeler? 😅

@jni jni added the documentation Improvements or additions to documentation label Nov 19, 2024
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @jni! Greatly appreciated 🙏

@DragaDoncila DragaDoncila added this to the 0.5.5 milestone Nov 19, 2024
@melissawm
Copy link
Member

Labeler works again, thanks @psobolewskiPhD !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants