-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Labels] Add more prominent info about the next label keybind and fix n_dimensional (deprecated) #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobolewskiPhD
added
bug
Something isn't working
documentation
Improvements or additions to documentation
content
Ideas for new or improved content
labels
Nov 18, 2024
DragaDoncila
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks Peter, just nitpicked some typos 🙏
Co-authored-by: Draga Doncila Pop <[email protected]>
jni
approved these changes
Nov 21, 2024
jni
pushed a commit
to napari/napari
that referenced
this pull request
Nov 21, 2024
# References and relevant issues `n_dimensional` was removed in #3377 # Description I came across a reference to `n_dimensional` in the docs and realized it didn't exist. In this PR I remove it from the test and example. Here's the docs PR where I also switch to the proper property: napari/docs#522 Co-authored-by: Draga Doncila Pop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
content
Ideas for new or improved content
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Related to napari/napari#7354
Description
In this PR I make more prominent the information that the
m
key will select a new, unique label. I usedtip
admonitions.While doing this I noticed that the labels guide mentions
n_dimensional
which has long been deprecated, so I fix that too.