Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Labels] Add more prominent info about the next label keybind and fix n_dimensional (deprecated) #522

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

Related to napari/napari#7354

Description

In this PR I make more prominent the information that the m key will select a new, unique label. I used tip admonitions.
While doing this I noticed that the labels guide mentions n_dimensional which has long been deprecated, so I fix that too.

@psobolewskiPhD psobolewskiPhD added bug Something isn't working documentation Improvements or additions to documentation content Ideas for new or improved content labels Nov 18, 2024
@psobolewskiPhD psobolewskiPhD added this to the 0.5.5 milestone Nov 18, 2024
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Peter, just nitpicked some typos 🙏

docs/howtos/layers/labels.md Outdated Show resolved Hide resolved
docs/howtos/layers/labels.md Outdated Show resolved Hide resolved
jni pushed a commit to napari/napari that referenced this pull request Nov 21, 2024
# References and relevant issues
`n_dimensional` was removed in
#3377

# Description
I came across a reference to `n_dimensional` in the docs and realized it
didn't exist.
In this PR I remove it from the test and example.
Here's the docs PR where I also switch to the proper property:
napari/docs#522

Co-authored-by: Draga Doncila Pop <[email protected]>
@DragaDoncila DragaDoncila merged commit e192a22 into napari:main Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working content Ideas for new or improved content documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants