Fix broken links detected by make linkcheck-files #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
psobolewskiPhD
requested changes
Aug 27, 2024
psobolewskiPhD
approved these changes
Sep 27, 2024
|
Thanks!! |
|
Hi all - any other suggestions here? |
DragaDoncila
approved these changes
Oct 23, 2024
|
Sorry I dropped the ball on this one 😭 |
DragaDoncila
pushed a commit
that referenced
this pull request
Nov 8, 2024
# References and relevant issues Closes #439 Closes #328 Depends on #484 # Description Adds a sphinx linkcheck step to be run once a week. The reported failures will show up as issues in the repo. This check can also be triggered manually. I am using the sphinx linkchecker as it will check all links in the docs, including those coming from docstrings. You can see this in action on my fork, here: melissawm#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Related to
#474
Description
Fixes a number of broken links detected by
make linkcheck-files.A few comments:
further-resources/sample_data.md:17: [redirected permanently] [digitalpathologyassociation.org/whole-slide-imaging-repository](https://digitalpathologyassociation.org/whole-slide-imaging-repository) to [https://digitalpathologyassociation.org?preview_error](https://digitalpathologyassociation.org/?preview_error). I tried googling but only found this: http://www.wsirepository.org/ and it doesn't load. Any ideas?developers/architecture/app_model.md:288: [broken] https://github.com/napari/napari/blob/main/napari/_app_model/_submenus.py: 404 Client Error: Not Found for url: https://github.com/napari/napari/blob/main/napari/_app_model/_submenus.pyI couldn't find SubmenuItem in the codebase, maybe I'm missing somethingtutorials/tracking/cell_tracking.md:229: [broken] https://github.com/quantumjot/btrack/blob/main/models/cell_config.json: 404 Client Error: Not Found for url: https://github.com/quantumjot/btrack/blob/main/models/cell_config.json. Should we replace with a new link?A few items are left, mostly links to old code. I will try to replace with permalinks where I can, but not sure if I'll be able to find all of them. If that's the case I might try to ping the original authors for an appropriate substitution.