-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic layer modes description, including transform button #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an initial pass, only a couple comments. Thanks @dalthviz !
docs/howtos/layers/shapes.md
Outdated
|
||
Use this tool to rotate, scale, or translate the layer. To reset the transformation, | ||
you can Option/Alt-click the transform button (a confirmation dialog will open to | ||
confirm the reset). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 6
and 7
keyboard shortcuts are also valid here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @melissawm thanks for the review! You mean changing this to be something like:
Use this tool to rotate, scale, or translate the layer. To activate the tool, you can
press `7`. To reset the transformation, you can Option/Alt-click the transform
button (a confirmation dialog will open to confirm the reset).
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - and add the information about the keyboard shortcut to the pan/zoom tool as well if you can. Thanks!
Co-authored-by: Melissa Weber Mendonça <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @dalthviz !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz
I made a few suggestions to clarify that translate only works in 2D viewer mode.
I'm still not sure we should be even more explicit that it works on 3D layers but only in 2D viewer mode?
Also I tried to clarify the pan/zoom bit -- I'd prefer we use the 0.4.19 arrows/pan icon.
Co-authored-by: Peter Sobolewski <[email protected]>
I would say the added note should be enough but maybe asking for feedback to others could be worthy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz !
Looks good to me.
References and relevant issues
Depends on napari/napari#6794
Description
Adds new content related with layers transform mode and base possible values (
pan_zoom
andtransform
)