Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic layer modes description, including transform button #420

Merged
merged 11 commits into from
Jul 11, 2024

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented May 8, 2024

References and relevant issues

Depends on napari/napari#6794

Description

Adds new content related with layers transform mode and base possible values (pan_zoom and transform)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 8, 2024
@dalthviz dalthviz marked this pull request as ready for review May 14, 2024 16:45
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial pass, only a couple comments. Thanks @dalthviz !

docs/guides/layers.md Outdated Show resolved Hide resolved
docs/guides/layers.md Outdated Show resolved Hide resolved

Use this tool to rotate, scale, or translate the layer. To reset the transformation,
you can Option/Alt-click the transform button (a confirmation dialog will open to
confirm the reset).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 6 and 7 keyboard shortcuts are also valid here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melissawm thanks for the review! You mean changing this to be something like:

 Use this tool to rotate, scale, or translate the layer. To activate the tool, you can
 press `7`. To reset the transformation, you can Option/Alt-click the transform
 button (a confirmation dialog will open to confirm the reset).

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - and add the information about the keyboard shortcut to the pan/zoom tool as well if you can. Thanks!

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz !

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz
I made a few suggestions to clarify that translate only works in 2D viewer mode.
I'm still not sure we should be even more explicit that it works on 3D layers but only in 2D viewer mode?
Also I tried to clarify the pan/zoom bit -- I'd prefer we use the 0.4.19 arrows/pan icon.

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Jun 6, 2024
@dalthviz
Copy link
Member Author

dalthviz commented Jun 7, 2024

I'm still not sure we should be even more explicit that it works on 3D layers but only in 2D viewer mode?

I would say the added note should be enough but maybe asking for feedback to others could be worthy

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz !
Looks good to me.

@psobolewskiPhD psobolewskiPhD changed the title [WIP] Add basic layer modes description Add basic layer modes description, including transform button Jun 7, 2024
@jni jni merged commit b6b61df into napari:main Jul 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants