Add page on magicgui type registration
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
4 tasks
|
Thank you @DragaDoncila! I've updated |
There was a problem hiding this comment.
@lucyleeow sorry, couple more comments. I think this is looking good!
| `choices` callable. This callable is either `get_layers_data` or `get_layers`. | ||
| These functions retrieve the closest parent `Viewer` of the native | ||
| {class}`~magicgui.widgets.bases.CategoricalWidget` widget and returns a list of | ||
| {class}`~napari.layers.Layer` or tuple of format ('layer name', `<LayerType>Data`). |
There was a problem hiding this comment.
Suggested change
| {class}`~napari.layers.Layer` or tuple of format ('layer name', `<LayerType>Data`). | |
| {class}`~napari.layers.Layer` or tuple of format `(layer name, <LayerType>Data)`. |
|
Thanks @DragaDoncila, changes made! |
DragaDoncila
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
@lucyleeow approved with just two more comments to break up a big paragraph (looks a bit intense on the built docs otherwise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Came about after #68
Details
magicguitype registration, in particular thereset_choicesconnection to layers we do for all widgets that have that method.