-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc preview in PR CI #389
Conversation
lucyleeow
commented
Apr 6, 2024
•
edited
Loading
edited
- Update names downloading artifacts: we changed workflow name and build dir from 'docs' to 'html' -> this updates this and updates the images to match new names
- Adds more info on difference between local vs PR preview and circle CI vs artifact download preview.
Wait, that's the contributing documentation guide, so for this repo. (That said on napari/napari it's just circleCI now, which is fine I think because most docs things will go through this repo.) |
No problem, we can document both. Still need to update the docs as we get to the artifact a different way now. |
I've updated everything (since we updated the CIs things have changed names) - hopefully its okay, I'll come back and double check later! |
🤦 oh man I just realised that you could still download the artifact and the old docs described how to do both and were fine really. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks @lucyleeow !