Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for New from clipboard feature #307

Merged
merged 17 commits into from
Mar 7, 2024

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

Depends on napari/napari#6532

Description

This PR adds mentions of the new feature: File menu item New Image from Clipboard to the viewer tutorial as well as the getting started and quick start guides.

@psobolewskiPhD psobolewskiPhD added the documentation Improvements or additions to documentation label Dec 19, 2023
@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Dec 19, 2023
Copy link
Collaborator

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don't know why files tab looks like this though:

image

Maybe it's just me?

@psobolewskiPhD
Copy link
Member Author

@lucyleeow I have no idea, I see similar on my end. The whole file is weird:
https://github.com/napari/docs/blob/main/docs/tutorials/fundamentals/quick_start.md?plain=1

@lucyleeow
Copy link
Collaborator

True! I wonder if it has anything to do with the jupytext header (clutching at straws though):

jupytext:
formats: ipynb,md:myst

Maybe @melissawm will know why?

@melissawm
Copy link
Member

True! I wonder if it has anything to do with the jupytext header (clutching at straws though):

jupytext:
formats: ipynb,md:myst

Maybe @melissawm will know why?

That may be it. We could probably remove the formats line anyway as we don't need to keep any notebooks synchronized here.

Copy link
Contributor

@GenevieveBuckley GenevieveBuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, my only suggestion is to change the phrasing from "an image in your Clipboard" to "an image copied to your Clipboard".

I think it's useful to have the word "copy" in the sentence since we have a lot of non-native English speakers who use napari. I think it makes it a bit easier for people to remember that "Clipboard" is related to copy-paste actions if we provide the extra context clue.

Co-authored-by: Genevieve Buckley <[email protected]>
@psobolewskiPhD
Copy link
Member Author

@GenevieveBuckley Excellent point, thanks for that. I've committed the suggestions!
❤️

@GenevieveBuckley GenevieveBuckley merged commit 88682c4 into napari:main Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants