-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reference labels instead of paths #301
Conversation
Sorry it's not going to be fun to review. I also sort of regret taking this on 😬 |
Yea 😅 |
Do you think thats going to be much easier to review than this PR? |
I have no idea 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through everything and it's great!
Just a couple small nits...
...plus merge conflicts 😬
Oooff I just realised, let me have a look. I am worried the merge conflicts are too complex after my extending napari PR re-organise. I'm tempted to abandon this PR, WDYT? |
Okay the conflicts were not as bad as I imagined. I was worried because I had moved files around in other PRs that have now been merged. @psobolewskiPhD thanks for the review, changes made! (if possible would be great to get this in to avoid more merge conflicts!) |
Thanks for your efforts @lucyleeow |
@psobolewskiPhD ping, can this go in? Thank you 🙏 |
Done--sorry & thanks. |
References and relevant issues
towards #296
Description
Uses references labels instead of paths. A few notes:
docs/plugins/virtual_environment_docs
as they just reference files within that folder so I think we're safegallery/
links. Does sphinx-tag automatically generate the gallery index/readme page..?-
between words in reference labelsnapari
from some reference labels, as there is no 'plugin' equivalent thus its obvs it is about napari