-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use napari-sphinx-theme 0.3.0 #267
Conversation
This will also require the constraints -- which are in napari/napari -- to get updated once the new theme is released. |
Is the new theme is incompatible with the old one and could break 0.4.19 build docs process? |
@Czaki is the theme not part of the constraints? |
Is. but we do not have upper constraints at this moment. So I would like to know if I should add it in the 0.4.19 branch. |
I thought constraints were pins? That's what I was asking anyway. Maybe this PR could get backported? It seems unobtrusive enough... Can't wait to have the new theme! But up to you. We can wait to release the theme until after 0.4.19. |
I have a plan to refresh constraints before release 0.4.19. If a new theme is released earlier such a refresh will bring it in constraints. |
This was discussed at the docs working group meeting today. The consensus was to wait until after 0.4.19 release, with the goal of the next release being 0.5.0 and using the split repo setup rather than cherry picking and getting a fresh look! |
bd646bd
to
7969235
Compare
7969235
to
e0cab90
Compare
This is rebased and should be ready to go along with napari/napari-sphinx-theme#134 |
@melissawm the CI disagrees... 😅 Perhaps you can point it to your branch for now, with a comment that it needs to be updated to depend on |
Yeah I was assuming this would only go in after the theme was updated, but I can do this for the preview. |
ee81cda
to
aef185e
Compare
Ok it looks like it's alive - you can see it here https://output.circle-artifacts.com/output/job/c9c574d3-71c6-434f-b5ab-85bdb7ff68c3/artifacts/0/docs/docs/_build/index.html?pr=267 🥳 (note the calendar events are not showing up since we don't use the calendar API key in the circleci set up - I can fix that in a separate commit. The deploy does have the correct env variable set up though.) |
40f4cd6
to
cb3b9e6
Compare
Ok, here's a new attempt! This time I decided to try my hand at javascript (just a little 😅 ) How does that look? https://melissawm.github.io/napari-theme-var/community/meeting_schedule.html |
Looks awesome to me! |
It's a bit annoying the docs pip constraints are in the other repo.
Edit: except that |
…#134) Refactors colors, styling and fonts from napari-sphinx-theme. Also removes extra react components that are not needed for the napari theme. Includes the community calendar feature, but calendar is now managed on the docs side. To see how this would look like, you can fetch this PR and build the docs locally (after fetching napari/docs#267), or you can see the deployed site here: melissawm.github.io/napari-theme-var # Important After merging, this will also require a new release of the napari-sphinx-theme. Closes #113 See also napari/docs#267 # List of commits * Full refactor of napari-sphinx-theme to depend on pydata-sphinx-theme * Addressing review comments * Clean up previous theme configs * Move napari logo to partials * Update README * Fix accent color for search box * Set version number * Pin pydata-sphinx-theme version and fix calendar event display
Please squash before merging 😄 |
Alas, I can't get the pip-tools thing to work (testing on current stuff) because I'm on arm64 and there are missing wheels (triangle, pyside2, maybe more). I guess it should be run under linux, like CI? |
Oh and we need a release of the theme! |
@jni has cut a 0.3.0 release of the theme so we're good there 🎉 @psobolewskiPhD I'm on linux so if you point me to the instructions I might be able to update the constraints, let me know! |
Correction: @jni attempted to push a 0.3.0 release, but the workflow failed. 😂 See https://pypi.org/project/napari-sphinx-theme/ and napari/napari-sphinx-theme#135. |
# References and relevant issues Related to napari/napari-sphinx-theme#134, napari/docs#267 # Description Updates docs constraints file for the new napari-sphinx-theme release.
For anyone coming across this and related PRs, sorry about the fast merges, but @melissawm, @psobolewskiPhD, and I happened to coincide sync and we worked together on merging all of these in sequence, forgoing protocol, since they all depend on each other and merging some but not others could result in broken builds and other inconsistencies. The related PRs are:
You can relive all the action in the docs-wg thread on Zulip! We now resume our regularly scheduled programming. But check out the new docs! 😍 https://napari.org/dev (new on left, old on right) |
Prepares the docs repo to use the new napari-sphinx-theme, 0.3.0, which depends on pydata-sphinx-theme rather than forking it.
References and relevant issues
Addresses napari/napari-sphinx-theme#113
Depends on napari/napari-sphinx-theme#134