Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-breaking spaces with regular spaces #118

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Replace non-breaking spaces with regular spaces #118

merged 1 commit into from
Mar 7, 2023

Conversation

ctrueden
Copy link
Contributor

@ctrueden ctrueden commented Mar 7, 2023

Description

The   character causes various difficulties and confusion, such as the docs/howtos/docker.md document's "For development" header not being rendered as a header by Markdown renderers.

Type of change

  • Fixes or improves existing content

Final checklist:

  • My PR is the minimum possible work for the desired functionality

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 7, 2023
The   character causes various difficulties and confusion,
such as the docs/howtos/docker.md document's "For development"
header not being rendered as a header by Markdown renderers.
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are/were located pretty randomly, wow...

@ctrueden
Copy link
Contributor Author

ctrueden commented Mar 7, 2023

Those are/were located pretty randomly, wow...

I know right? 😆

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are probably artifacts of specific editors - happy you caught them, thanks!

@Czaki
Copy link
Contributor

Czaki commented Mar 7, 2023

These are probably artifacts of specific editors - happy you caught them, thanks!

Alt+Space could be used to input non-breaking space, so it may happen by accident.

@jni jni merged commit d5e7184 into napari:main Mar 7, 2023
@brisvag
Copy link
Contributor

brisvag commented Mar 8, 2023

Is there a precommit way of dealign with these?

@Czaki
Copy link
Contributor

Czaki commented Mar 8, 2023

There are multiple markdown pre-commit hooks listed in https://pre-commit.com/hooks.html, but someone needs to check which one is best.

melissawm pushed a commit to melissawm/napari-docs that referenced this pull request Apr 26, 2023
# Description

The ` ` character causes various difficulties and confusion, such
as the `docs/howtos/docker.md` document's "For development" header not
being rendered as a header by Markdown renderers.

## Type of change

- [x] Fixes or improves existing content

## Final checklist:

- [x] My PR is the minimum possible work for the desired functionality
@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants