Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest build_deploy workflow deleted dev on deploy to gh-pages #383

Closed
psobolewskiPhD opened this issue Apr 5, 2024 · 4 comments · Fixed by #384
Closed

Latest build_deploy workflow deleted dev on deploy to gh-pages #383

psobolewskiPhD opened this issue Apr 5, 2024 · 4 comments · Fixed by #384
Labels
bug Something isn't working priority-high

Comments

@psobolewskiPhD
Copy link
Member

🐛 Bug

napari.org latest is a 404 because dev/ is deleted
napari/napari.github.io@3a3d212

While the commit is a different PR, it's because of concurrency--two PR merged at the same time basically.
The issue lies with the workflow edited here:
#380
Could also be the tags issue raised during review of #348
@psobolewskiPhD psobolewskiPhD added bug Something isn't working priority-high labels Apr 5, 2024
@DragaDoncila
Copy link
Contributor

Noooo I'm sorry! 😢 That's what I get for merging in a repo I haven't been fully keeping upwith. What's the solution here - can we manually deploy just to get them back up?

@lucyleeow
Copy link
Collaborator

Even stable looks weird, but maybe thats just me?

image

@psobolewskiPhD psobolewskiPhD mentioned this issue Apr 5, 2024
Merged
@psobolewskiPhD
Copy link
Member Author

Hmm I think stable was using something from dev -- the version switcher and the announcement?
So with dev being deleted, that could explain it.
I think I have a fix...
#384

@psobolewskiPhD
Copy link
Member Author

Not your fault at all @DragaDoncila
There was an error in the original workflow that I tried to fix, but obviously failed.
It just looks like your merge is odd, but that's because the merge just before the actions were canceled.

psobolewskiPhD added a commit that referenced this issue Apr 5, 2024
@psobolewskiPhD
[Maint] fix build_and_deploy.yml paths (#384)
c6329fb 
# References and relevant issues
closes: #383 

The deploy workflow "works" but is deploying nothing:

https://github.com/napari/docs/actions/runs/8563891050/job/23469798992#step:4:1833
> cp: no such file or directory: /home/runner/work/docs/docs/docs/*

The artifact is extracted to:

https://github.com/napari/docs/actions/runs/8563891050/job/23469798992#step:2:12
> Starting download of artifact to: /home/runner/work/docs/docs
> ...
> Extracting artifact entry:
/home/runner/work/docs/docs/_images/3D-button.png

There is confusing paths with docs and docs. It looks like the
deployment is relative to the last working dir and not the top-level.

# Description
In this PR I set the path of the download action to `html` (instead of
downloading by name, which shouldn't matter here) which should make
things clearer and then use that for the deployment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maint] fix build_and_deploy.yml paths psobolewskiPhD/napari-docs
3 participants
@DragaDoncila @lucyleeow @psobolewskiPhD