Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NOTICE #992

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Create NOTICE #992

merged 4 commits into from
Apr 17, 2020

Conversation

eckelcu
Copy link
Contributor

@eckelcu eckelcu commented Jun 7, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jun 7, 2019

Coverage Status

Coverage remained the same at 0.0% when pulling eccbf22 on eckelcu:patch-1 into bd0908b on napalm-automation:develop.

@ktbyers
Copy link
Contributor

ktbyers commented Jun 11, 2019

@eckelcu Why?

If we do that we should include the Apache2 notice right below that as all the code in here is under the Apache2 license. Also Spotify only is a relatively small part of the code at this point.

@eckelcu
Copy link
Contributor Author

eckelcu commented Jun 11, 2019

This is an attempt to satisfy this requirement of applying the Apache 2.0 license to your code, https://www.apache.org/licenses/LICENSE-2.0#apply

Admittedly, it would be best to add the Apache 2.0 license boilerplate to every source file, but short of doing that, I am proposing to identify the copyright owner in a single NOTICE file.

I saw the Spotify copyright in some other files, e.g. https://github.com/napalm-automation/napalm/blob/develop/napalm/base/base.py, so I went with that.

@eckelcu
Copy link
Contributor Author

eckelcu commented Jun 11, 2019

Here is an example from Apache of a notice file https://apache.org/licenses/example-NOTICE.txt

@ktbyers
Copy link
Contributor

ktbyers commented Jun 11, 2019

Okay, we should also probably add the set of committers to it as well (as Spotify contributed very little of the code at this point). DBarroso has committed a lot, but I think most of it was probably post spotify.

@mirceaulinic
Copy link
Member

Checking in here @eckelcu, any chance to update as per Kirk's suggestion?

@eckelcu
Copy link
Contributor Author

eckelcu commented Apr 15, 2020

Happy too. I have updated as suggested @ktbyers @mirceaulinic

@@ -0,0 +1,7 @@
napalm
Copyright 2015 Spotify AB. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a matter I thought about it, seems still unclear.
What about adding another line here like:

Copyright 2016-2020 NAPALM Automation Team. All rights reserved.

Any thoughts @ktbyers @dbarrosop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a lawyer, but my understanding is there should be a single copyright notice only and that identifies the copyright owner at the time the work was first published. The owner should be a legal entity (a person, their employer, an organization, etc.)

@dbarrosop
Copy link
Member

dbarrosop commented Apr 17, 2020

I am no lawyer either and I have no strong opinons but I don't think a NOTICE file is needed. Apache 2 license only requires a LICENSE file in the root of the project and the rest of the content, unless specified otherwise, inherits this LICENSE. From the LICENSE itself:

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

In any case, I am not against adding it if that pleases some stubborn lawyer at some stubborn firm working for a stubborn enterprise :D

@mirceaulinic mirceaulinic merged commit 8b1e986 into napalm-automation:develop Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants