VLAN table information for JunOS

[ckozler]

No description provided.

[ckozler]

Related to #1366

[ckozler]

Sample output

./bin/napalm --vendor junos -u root --optional_args keepalive=600,auto_probe=600,timeout=600 x.x.x.x call get_vlans
{
"default": {
"name": "default",
"tag": "1",
"members": [
"ge-0/0/0.0*",
"ge-0/0/1.0*",
"ge-0/0/2.0*",
"ge-0/0/3.0*",
"ge-0/0/30.0*",
"ge-1/0/0.0*",
"ge-1/0/1.0*",
"ge-1/0/2.0*"
]
},
"vlan2_MGMT": {
"name": "vlan2_MGMT",
"tag": "2",
"members": "ae0.0*"
},
"vlan3_TEST": {
"name": "vlan3_TEST",
"tag": "3",
"members": "none-assigned"
}
}

[mirceaulinic]

Good start, thanks for the PR. Please install the test dependencies from requirements-dev.txt and run black . to format your text properly.

Would also need to add tests for this; locally you can run tox to ensure everything is fine.

[mirceaulinic]

This should be just an empty list instead of "none-assigned".

[ckozler]

OK I can change that. I put this as a catch-all but an empty list as a catch all works too

[mirceaulinic]

How's it going? :)

[ckozler]

I have been working on implementing this along side network-importer tools (https://github.com/networktocode/network-importer/) but I can submit the change you recommended to get this moved up. I originally started this because of of network-importer so I wanted to make sure it'd work with it

[mirceaulinic]

As you wish, @ckozler - if you want to continue working on this with the requested changes, and the tests, I'll be happy to review; otherwise, feel free to close it out. 👍

[mirceaulinic]

Closing out due to inactivity.

@ckozler if you wanted to continue working on this, let me know and I'll gladly reopen, or feel free to open a separate PR. Remember, the data structure return must align to the NAPALM model, which must be respected to every driver implementing the method: https://github.com/napalm-automation/napalm/blob/develop/napalm/base/test/models.py#L267.

[minefuto]

Hi @ckozler,
I want to use get_vlans on Junos but it seems this PR is inactivity.
May I submit a PR on behalf of you?