Merge pull request #1966 from jlixfeld/last_flapped

Use `LastStateTransitionTime` to populate `last_flapped` for `get_interfaces()` in IOS-XR
napalm-automation · Mar 21, 2024 · f432be6 · f432be6
2 parents aa91517 + f4a73a4
commit f432be6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/napalm/iosxr/iosxr.py b/napalm/iosxr/iosxr.py
@@ -302,6 +302,13 @@ def get_interfaces(self):
 
             mtu = int(napalm.base.helpers.find_txt(interface_tree, "MTU"))
             description = napalm.base.helpers.find_txt(interface_tree, "Description")
+            last_flapped = napalm.base.helpers.convert(
+                float,
+                napalm.base.helpers.find_txt(
+                    interface_tree, "LastStateTransitionTime", -1
+                ),
+                -1,
+            )
             interfaces[interface_name] = copy.deepcopy(INTERFACE_DEFAULTS)
             interfaces[interface_name].update(
                 {
@@ -311,6 +318,9 @@ def get_interfaces(self):
                     "is_enabled": enabled,
                     "mac_address": mac_address,
                     "description": description,
+                    "last_flapped": last_flapped / 1e9
+                    if last_flapped != -1.0
+                    else -1.0,
                 }
             )
 

diff --git a/...d_data/test_get_interfaces/normal/_Get__Operational__Interfaces____Operational___Get_.txt b/...d_data/test_get_interfaces/normal/_Get__Operational__Interfaces____Operational___Get_.txt
@@ -287,6 +287,9 @@
                         <StateTransitionCount>
                             0
                         </StateTransitionCount>
+                        <LastStateTransitionTime>
+                            1682947558700282575
+                        </LastStateTransitionTime>
                         <IsDampeningEnabled>
                             false
                         </IsDampeningEnabled>

diff --git a/test/iosxr/mocked_data/test_get_interfaces/normal/expected_result.json b/test/iosxr/mocked_data/test_get_interfaces/normal/expected_result.json
@@ -2,7 +2,7 @@
 	"TenGigE0/0/0/14": {
 		"is_enabled": true,
 		"description": "",
-		"last_flapped": -1.0,
+		"last_flapped": 1682947558.7002826,
 		"is_up": false,
 		"mac_address": "E0:AC:F1:64:71:52",
 		"mtu": 1514,