Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demos: bump cmake version required to 3.15 #2031

Merged
merged 1 commit into from
Dec 29, 2024
Merged

demos: bump cmake version required to 3.15 #2031

merged 1 commit into from
Dec 29, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 29, 2024

This fixes problems finding the threads library. There may still be problems building these with TLS libraries added, as those dependencies may not be satisfied if the library lacks a cmake configuration file.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This fixes problems finding the threads library.  There may
still be problems building these with TLS libraries added,
as those dependencies may not be satisfied if the library lacks
a cmake configuration file.
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (b5462f6) to head (60ff324).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
- Coverage   82.69%   82.62%   -0.07%     
==========================================
  Files          95       95              
  Lines       23656    23656              
  Branches     3044     3044              
==========================================
- Hits        19562    19546      -16     
- Misses       4023     4036      +13     
- Partials       71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 60ff324 into main Dec 29, 2024
35 of 36 checks passed
@gdamore gdamore deleted the demo-cmake-315 branch December 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant