Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #961 surprising pipe event order #2027

Merged
merged 1 commit into from
Dec 29, 2024
Merged

fixes #961 surprising pipe event order #2027

merged 1 commit into from
Dec 29, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 29, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

@gdamore
Copy link
Contributor Author

gdamore commented Dec 29, 2024

This uses a single serialization mutex for ALL pipe callbacks.

Needless to say, this can have an impact for scalability of systems that have vast amounts of churn in the the number of connected pipes (which is an antipattern for NNG btw), or where the pipe event callbacks do non-trivial amounts of work.

It is important that pipe event callbacks finish promptly. Otherwise they can have a pretty bad impact on the overall system. This was true before this logic was added, and it remains true.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (bef6b37) to head (67b4cea).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/socket.c 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   82.63%   82.52%   -0.12%     
==========================================
  Files          95       95              
  Lines       23653    23667      +14     
  Branches     3041     3044       +3     
==========================================
- Hits        19546    19531      -15     
- Misses       4037     4065      +28     
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 67b4cea into main Dec 29, 2024
33 of 36 checks passed
@gdamore gdamore deleted the pipe-ev-order branch December 29, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant