Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for potential leaking connections #2023

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix for potential leaking connections #2023

merged 1 commit into from
Dec 27, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 27, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (c64d0e5) to head (5183093).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/sp/transport/tls/tls.c 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
+ Coverage   82.48%   82.52%   +0.03%     
==========================================
  Files          95       95              
  Lines       23714    23723       +9     
  Branches     3050     3053       +3     
==========================================
+ Hits        19561    19577      +16     
+ Misses       4081     4074       -7     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 5183093 into main Dec 27, 2024
35 of 36 checks passed
@gdamore gdamore deleted the fix-leaking-conns branch December 27, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant