Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estopped #2019

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Estopped #2019

merged 2 commits into from
Dec 26, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 26, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 71.05263% with 22 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (d6ed8c8) to head (06ebeef).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/core/aio.c 70.58% 20 Missing ⚠️
src/sp/transport/udp/udp.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
- Coverage   82.17%   82.00%   -0.17%     
==========================================
  Files          95       95              
  Lines       23912    23972      +60     
  Branches     3142     3147       +5     
==========================================
+ Hits        19650    19659       +9     
- Misses       4190     4240      +50     
- Partials       72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This error code results when an AIO is stopped permanently, as a result
of nni_aio_close or nni_aio_stop.  The associated AIO object cannot be
used again.  This discrimantes against a file being closed, or a temporary
cancellation which might allow the aio to be reused.

Consumers must check for this error status in their callbacks, and not
resubmit an operation that failed with this error.  Doing so, will result
in an infinite loop of submit / errors.
@gdamore gdamore merged commit 06ebeef into main Dec 26, 2024
35 of 37 checks passed
@gdamore gdamore deleted the estopped branch December 27, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant