Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc transport: convert to using inline data structures #1982

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 8, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (2ade67c) to head (c889453).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/sp/transport/ipc/ipc.c 88.70% 7 Missing ⚠️
src/sp/transport/udp/udp.c 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.02%     
==========================================
  Files          95       95              
  Lines       24077    24057      -20     
  Branches     3208     3201       -7     
==========================================
- Hits        19728    19708      -20     
+ Misses       4274     4273       -1     
- Partials       75       76       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore force-pushed the ipc-inline branch 6 times, most recently from d7df456 to f292cc6 Compare December 9, 2024 06:22
This should allow us to stop the endpoints early, without freeing
them.  This ensures that pipe creation has ended before we start
tearing down pipes.
@gdamore gdamore merged commit c889453 into main Dec 11, 2024
18 of 19 checks passed
@gdamore gdamore deleted the ipc-inline branch December 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant