Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctx: Simplify handling for closed contexts. #1972

Merged
merged 1 commit into from
Dec 7, 2024
Merged

ctx: Simplify handling for closed contexts. #1972

merged 1 commit into from
Dec 7, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 7, 2024

Once a context has started the process of close, further attempts to close it will return NNG_ECLOSED. What was I thinking to ever do anything else?

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Once a context has started the process of close, further attempts
to close it will return NNG_ECLOSED.  What was I thinking to ever
do anything else?
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (4f940ce) to head (3dfa962).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nng.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
+ Coverage   81.86%   81.89%   +0.03%     
==========================================
  Files          95       95              
  Lines       24074    24074              
  Branches     3209     3209              
==========================================
+ Hits        19707    19716       +9     
+ Misses       4295     4287       -8     
+ Partials       72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 3dfa962 into main Dec 7, 2024
16 of 19 checks passed
@gdamore gdamore deleted the ctx-close branch December 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant