Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1740 Public ID hash API #1748

Merged
merged 1 commit into from
Dec 30, 2023
Merged

fixes #1740 Public ID hash API #1748

merged 1 commit into from
Dec 30, 2023

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 30, 2023

This includes a manual page documenting the entire set of functions in one step. The hash is 64-bit based for now, to be maximally flexible. An internal 32-bit convenience for the common internal use is also provided (not public).

The public API includes a test suite.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This includes a manual page documenting the entire set of
functions in one step.  The hash is 64-bit based for now, to
be maximally flexible.  An internal 32-bit convenience for the
common internal use is also provided (not public).

The public API includes a test suite.
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5954332) 79.23% compared to head (3298ac1) 79.20%.

Files Patch % Lines
src/core/idhash.c 91.66% 1 Missing ⚠️
src/supplemental/idhash/idhash.c 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   79.23%   79.20%   -0.04%     
==========================================
  Files          93       94       +1     
  Lines       20990    21013      +23     
==========================================
+ Hits        16632    16643      +11     
- Misses       4358     4370      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 3298ac1 into master Dec 30, 2023
17 of 18 checks passed
@gdamore gdamore deleted the gdamore/idhash-public branch December 30, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant