-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close pipe by ID #7
Comments
nng_msg_get_pipe() already exists now. |
This is fixed now, but we need a test for it. |
The pipe_close_test branch validates this -- but we can confirm that this is now working at any rate. |
This was referenced May 7, 2020
Closed
muryliang
pushed a commit
to muryliang/nng
that referenced
this issue
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For messages, we could store the PIPE ID as a message property. This could then be used by the application to conditionally close the underlying pipe (if it still exists). Using IDs here would solve questions about use-after-free, and avoid needing to hold any locks or long term reference counts.
The text was updated successfully, but these errors were encountered: