Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nng_sockaddr could just be a union #289

Closed
gdamore opened this issue Mar 14, 2018 · 0 comments
Closed

nng_sockaddr could just be a union #289

gdamore opened this issue Mar 14, 2018 · 0 comments

Comments

@gdamore
Copy link
Contributor

gdamore commented Mar 14, 2018

The current definition of nng_sockaddr contains only one member, s_un.

This is kind of pointless, and makes for more verbose and uglier code.

It would be cleaner to define this as:

union nng_sockaddr {
uint16_t s_family; // ...
nng_sockaddr_in s_in; // ... and so on
};

typedef struct nng_sockaddr nng_sockaddr;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant