* FIX [exchange_client] Clean up hashmap when ringbuffer is full #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanMaoyi
requested review from
StargazerWayne,
JaylinYu,
xinyi-xs and
wanghaEMQ
RanMaoyi
force-pushed
the
moi_ringbuffer
branch
from
f4c9f82 to
6353998
Compare
Signed-off-by: Moi Ran <[email protected]>
RanMaoyi
force-pushed
the
moi_ringbuffer
branch
from
6353998 to
c6d40b1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
- Coverage 65.71% 65.67% -0.04%
==========================================
Files 124 124
Lines 35993 36007 +14
==========================================
- Hits 23652 23648 -4
- Misses 12341 12359 +18 ☔ View full report in Codecov by Sentry. |
xinyi-xs
approved these changes
Dec 15, 2023
JaylinYu
approved these changes
Dec 15, 2023
Thank you for identifying the memory leak issue. If you wish to be part of the credit for this, go ahead! I don't mind. :P |
wanghaEMQ
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.